Add player labels for normal form game visuals#834
Open
edwardchalstrey1 wants to merge 2 commits intomasterfrom
Open
Add player labels for normal form game visuals#834edwardchalstrey1 wants to merge 2 commits intomasterfrom
edwardchalstrey1 wants to merge 2 commits intomasterfrom
Conversation
Member
Author
|
How it looks in the docs: 
|
Member
|
Immediate queries:
At the risk of scope creep there's a bunch of different ways we might output tables, and one of the problems we have right now is code duplication (as we discovered in the earlier PR #757). LaTeX and HTML tables have basically the same iteration just different output of symbols. Does it make sense to refactor to support possibly different outputs? For example markdown tables could be another possibility - not that we do that right now but it would become very easy to add with the right abstraction. But it might also just be too much? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues closed by this PR
Description of the changes in this PR
This PR adds player labels to the printout of normal form games:
How to review this PR